Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2] Prevent threading problems in TileMap #88916

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[4.2] Prevent threading problems in TileMap #88916

merged 1 commit into from
Feb 28, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Feb 27, 2024 •
edited
Loading

@AThousandShips AThousandShips added this to the 4.2 milestone Feb 27, 2024
@AThousandShips AThousandShips requested review from a team as code owners February 27, 2024 14:58
@akien-mga
Copy link
Member

Fails on Windows builds without (which I've temporarily included waiting for a cherry-pick):

Cherry-picked, so you can rebase this and the other PR where you had the same issue.

@AThousandShips AThousandShips removed the request for review from a team February 27, 2024 15:04
@akien-mga akien-mga merged commit 2fdeeea into godotengine:4.2 Feb 28, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the tile_thread_fix_4_2 branch February 28, 2024 12:36
@AThousandShips
Copy link
Member Author

Thank you!

@prvak prvak mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud Awaiting requested review from groud

Assignees
No one assigned
Labels
bug crash topic:2d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @akien-mga